Skip to content

Upgrade/Install: Restore the sync package files in the $_old_files array. - #13061

Closed
t-hamano wants to merge 3 commits into
WordPress:7.1from
t-hamano:65813-old-files-sync
Closed

Upgrade/Install: Restore the sync package files in the $_old_files array.#13061
t-hamano wants to merge 3 commits into
WordPress:7.1from
t-hamano:65813-old-files-sync

Conversation

@t-hamano

@t-hamano t-hamano commented Aug 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

wp-includes/js/dist/sync.js and sync.min.js were removed in 7.0.2, but came back in 7.1. This was not intentional.

The two paths are currently commented out in $_old_files with a "Restored in WordPress 7.1." note. This PR restores them as active entries so that upgrading to 7.1 deletes the leftover files.

Order of operations

These steps must be done in this order. Otherwise $_old_files will not match what is actually shipped.

  1. Merge Real-time collaboration: Bundle @wordpress/sync instead of exposing as wp.sync gutenberg#81683. The sync package is then no longer exposed as a separate script on Gutenberg's wp/7.1 branch.
  2. On the 7.1 branch of wordpress-develop, update the pinned Gutenberg hash to the latest commit of the wp/7.1 branch. sync.js and sync.min.js then disappear from core, and wp.sync is no longer exposed.
  3. Finally, commit this PR.

Trac ticket: https://core.trac.wordpress.org/ticket/65813

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5
Used for: Investigating when and why the files were reintroduced, and drafting this description. The change itself is a two-line edit that I reviewed and take responsibility for.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@t-hamano @claude
Upgrade/Install: Restore the sync package files in the $_old_files …
8bac23e 
…array.

Co-Authored-By: Claude <noreply@anthropic.com>
@t-hamano

t-hamano commented Aug 16, 2026

Copy link
Copy Markdown
Contributor Author
  1. On the 7.1 branch of wordpress-develop, update the pinned Gutenberg hash to the latest commit of the wp/7.1 branch. sync.js and sync.min.js then disappear from core, and wp.sync is no longer exposed.
  2. Finally, commit this PR.

Perhaps these two should be executed in a single commit.

@desrosj desrosj mentioned this pull request Aug 16, 2026
Closed
@desrosj

desrosj commented Aug 16, 2026

Copy link
Copy Markdown
Member

I've updated the gutenberg.sha value to include the change from WordPress/gutenberg#81683. After running the build script, the two files in question are now missing from the results.

@desrosj
desrosj marked this pull request as ready for review August 16, 2026 23:08
@github-actions

github-actions Bot commented Aug 16, 2026 •
edited
Loading

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props wildworks, desrosj, lancewillett.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

github-actions Bot commented Aug 16, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@lancewillett

lancewillett commented Aug 16, 2026

Copy link
Copy Markdown
Member

Reviewed and tested ✅.

No defects found; the change looks safe to commit to the 7.1 branch.

@t-hamano

t-hamano commented Aug 16, 2026

Copy link
Copy Markdown
Contributor Author

Thank you all for your reviews! I'm glad we could address this issue before the commit freeze. I plan to update the GB Hash one more time before the commit freeze, as there are still a few PRs that need to be backported to 7.1.

@github-actions

github-actions Bot commented Aug 16, 2026

Copy link
Copy Markdown

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 63316
GitHub commit: efb7a05

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions Bot closed this Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@desrosj desrosj desrosj approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@t-hamano @desrosj @lancewillett